Add Android smoke test for incremental Java compilation #11359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lptr
reviewed
Nov 14, 2019
Comment on lines
201
to
208
| when: | ||
| writeActivity(library, libPackage, libraryActivity, true) | ||
| result = runner('build', '-x', 'lint').build() | ||
|
|
||
| then: | ||
| result.task(':library:compileReleaseJavaWithJavac').outcome == TaskOutcome.SUCCESS | ||
| result.task(':app:compileReleaseJavaWithJavac').outcome == TaskOutcome.SUCCESS | ||
|
|
There was a problem hiding this comment.
It would be nice to somehow document that this is about incremental build. Add a comment? Move it to a separate test method?
There was a problem hiding this comment.
I added a name for the when/then methods. Do you think that is enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smoke test for #11330