Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not read the full file in-memory when computing checksums #11969

Merged
merged 1 commit into from Jan 22, 2020
Merged

Do not read the full file in-memory when computing checksums #11969

merged 1 commit into from Jan 22, 2020

Conversation

melix
Copy link
Contributor

@melix melix commented Jan 22, 2020

Fixes #11966

@melix melix added this to the 6.2 RC1 milestone Jan 22, 2020
@melix melix requested a review from jjohannes January 22, 2020 11:06
@melix melix self-assigned this Jan 22, 2020
jjohannes
jjohannes approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@jjohannes jjohannes left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@melix melix merged commit 074a82b into master Jan 22, 2020
@melix melix deleted the cc/dm/issue-11966 branch January 22, 2020 15:12
@melix
Copy link
Contributor Author

melix commented Jan 22, 2020

I'm going to backport this to 6.1.1 since it's a regression in memory consumption when publishing.

@melix melix modified the milestones: 6.2 RC1, 6.1.1 Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjohannes jjohannes jjohannes approved these changes

Assignees

@melix melix

Labels
a:bug in:dependency-management DO NOT USE
Projects
None yet
Milestone
6.1.1
Development

Successfully merging this pull request may close these issues.

Memory regression when resolving large artifacts while computing checksums
2 participants
@melix @jjohannes