Fix incorrect Gradle root build directory location #11976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also have prepared a branch merging into |
melix
force-pushed
the
cc/dm/issue-11971
branch
from
3e2b4db
to
91dcb8a
Compare
big-guy
reviewed
Jan 22, 2020
| @@ -334,8 +337,10 @@ RepositoryBlacklister createRepositoryBlacklister() { | |||
| return new ConnectionFailureRepositoryBlacklister(); | |||
| } | |||
|
|
|||
| StartParameterResolutionOverride createStartParameterResolutionOverride(StartParameter startParameter) { | |||
| return new StartParameterResolutionOverride(startParameter); | |||
| StartParameterResolutionOverride createStartParameterResolutionOverride(StartParameter startParameter, BuildLayoutFactory buildLayoutFactory) { | |||
There was a problem hiding this comment.
Can you use BuildLayout here? It should be a build scope service created in this same way.
There was a problem hiding this comment.
Nope, BuildLayout is not available at this stage.
big-guy
reviewed
Jan 22, 2020
|
Verification is not public in 6.1 so it doesn't matter really. |
This would cause a couple of bugs: - a `gradle` directory would be created for each build even if they didn't have one - a `gradle` directory would be created for subprojects if the gradle command was executed from this directory (#11971) In addition, this would cause the verification metadata file to be ignored if running from a subproject directory.
melix
force-pushed
the
cc/dm/issue-11971
branch
from
91dcb8a
to
aecda42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #11971