Make Gradle properties available to settings scripts #12401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamboo
added
from:member
a:bug
in:configuration-cache
bamboo
changed the title
PropertiesLoadingSettingsProcessor
To ensure `GradleProperties` is loaded before processing the settings scripts of any included builds. The integration with instant execution is mediated by the newly introduced `GradlePropertiesController` service which guarantees `GradleProperties` is loaded only once during a build and from the correct location. Fixes #12381
And mark it `@ToBeImplemented`.
…cation becomes available
…t scripts for buildSrc` As it cannot be safely implemented with the current init scripts semantics as init scripts can influence the settings file location thus influencing the location of the `gradle.properties` file.
…ct properties being available to buildSrc" This reverts commit 1a70869 Signed-off-by: Rodrigo B. de Oliveira <rodrigo@gradle.com>
Also test for the availability of Gradle properties in `settings.gradle`.
Restoring the pre-6.2 behavior.
- Make field final
… into buildSrc and included builds
The broken behavior is present in 6.2 and 6.2.1.
bamboo
force-pushed
the
bamboo/release/ie/composite-gradle-properties
branch
from
087a2f7
to
d4eff18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By ensuring
GradlePropertiesis loaded before processing the settings scripts of any included builds.The integration with instant execution is mediated by the newly introduced
GradlePropertiesControllerservice which guaranteesGradlePropertiesis loaded only once during a build and from the correct location.Fixes #12381