Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tracking of unattached dependencies #13350

Merged
merged 1 commit into from Jun 9, 2020
Merged

Improve tracking of unattached dependencies #13350

merged 1 commit into from Jun 9, 2020

Conversation

ljacomet
Copy link
Member

@ljacomet ljacomet commented Jun 5, 2020

When restarting an edge, it is possible that the new state fails to
compute the target node. In some cases, it is important to make sure the
detached edge is effectively tracked as an unattached edge.

This PR still needs a test illustrating the problem - work ongoing

@ljacomet ljacomet added this to the 6.6 RC1 milestone Jun 5, 2020
@ljacomet ljacomet requested a review from melix June 5, 2020 14:06
@ljacomet ljacomet self-assigned this Jun 5, 2020
melix
melix reviewed Jun 5, 2020
View reviewed changes
Copy link
Contributor

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is really becoming hairy. I'm not honestly sure I understand the fix, so can't really approve or request changes.

@melix
Copy link
Contributor

melix commented Jun 5, 2020

@ljacomet from my tests, this also fixes #13251

@ljacomet
Copy link
Member Author

ljacomet commented Jun 5, 2020

That's good news!

@ljacomet ljacomet force-pushed the ljacomet/dependency-management/graph-invalid branch from 6c307f6 to 4e5a8bb Compare June 8, 2020 09:28
@ljacomet ljacomet marked this pull request as ready for review June 8, 2020 09:28
@ljacomet
Copy link
Member Author

ljacomet commented Jun 8, 2020

@bot-gradle test RFM

@ljacomet
Copy link
Member Author

ljacomet commented Jun 8, 2020

@melix This PR is now complete, with a test. Can you take another look?

@bot-gradle
Copy link
Collaborator

OK, I've already triggered ReadyForMerge build for you.

@gradle gradle deleted a comment from bot-gradle Jun 8, 2020
melix
melix approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ljacomet ljacomet force-pushed the ljacomet/dependency-management/graph-invalid branch from 4e5a8bb to f1cff5b Compare June 8, 2020 12:17
@ljacomet
Copy link
Member Author

ljacomet commented Jun 8, 2020

@bot-gradle test RFM

@bot-gradle
Copy link
Collaborator

OK, I've already triggered ReadyForMerge build for you.

@ljacomet
Improve tracking of unattached dependencies
1b720bf 
When restarting an edge, it is possible that the new state fails to
compute the target node. In some cases, it is important to make sure the
detached edge is effectively tracked as an unattached edge.

Fixes #13251
Fixes #13316
@ljacomet ljacomet force-pushed the ljacomet/dependency-management/graph-invalid branch from f1cff5b to 1b720bf Compare June 9, 2020 14:08
@ljacomet ljacomet merged commit 1b720bf into master Jun 9, 2020
@ljacomet ljacomet deleted the ljacomet/dependency-management/graph-invalid branch June 9, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melix melix melix approved these changes

Assignees

@ljacomet ljacomet

Labels
in:dependency-management DO NOT USE
Projects
None yet
Milestone
6.6 RC1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ljacomet @melix @bot-gradle