Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renaming project directory causing lost file system notifications on Windows (Backport to 6.x) #17953

Merged

Conversation

lptr
Copy link
Member

@lptr lptr commented Aug 5, 2021

Fixes #17950

It's a backport of PR #17922.

@lptr lptr added the @execution label Aug 5, 2021
@lptr lptr added this to the 6.9.1 milestone Aug 5, 2021
@lptr lptr requested a review from wolfs August 5, 2021 10:57
@lptr lptr self-assigned this Aug 5, 2021
@lptr lptr changed the base branch from master to release6x August 5, 2021 10:58
@lptr lptr removed request for a team, ldaley, marcphilipp, pioterj and britter August 5, 2021 10:59
Copy link
Member

@wolfs wolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bot-gradle added a commit that referenced this pull request Aug 5, 2021
Backport to 6.9: Fix renaming project directory causing lost file system notifications on Windows
@gradle gradle deleted a comment from lptr Aug 12, 2021
@gradle gradle deleted a comment from lptr Aug 12, 2021
@gradle gradle deleted a comment from lptr Aug 13, 2021
@gradle gradle deleted a comment from bot-gradle Aug 13, 2021
@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

@bot-gradle
Copy link
Collaborator

Pre-tested commit build cancelled.

@blindpirate
Copy link
Collaborator

@bot-gradle test and merge please.

@gradle gradle deleted a comment from blindpirate Aug 13, 2021
@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

@bot-gradle bot-gradle merged commit 2d5d5dc into release6x Aug 13, 2021
@blindpirate blindpirate deleted the lptr/backport-6.x/vfs/fix-fsw-with-renames-on-windows branch August 13, 2021 12:55
@wolfs wolfs changed the title Backport to 6.9: Fix renaming project directory causing lost file system notifications on Windows Fix renaming project directory causing lost file system notifications on Windows (Backport to 6.x) Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants