Use the file resolver in LazyPublishArtifact #18715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-guy
requested changes
Oct 22, 2021
There was a problem hiding this comment.
This doesn't look like a bad change if it makes things more consistent, but it looks like there are some plugins relying on internal APIs that are busted by this: https://builds.gradle.org/viewLog.html?buildId=46767711&
The Play plugin we might be able to fix to avoid using internal APIs (we control it), but the Nebula and Spring plugins look more worrying.
octylFractal
force-pushed
the
ot/bugfix/provider-for-publish-artifact
branch
from
c80ffe9
to
5fff09b
Compare
octylFractal
force-pushed
the
ot/bugfix/provider-for-publish-artifact
branch
from
8e13524
to
804791e
Compare
big-guy
requested changes
Nov 10, 2021
...ency-management/src/main/java/org/gradle/api/internal/artifacts/dsl/LazyPublishArtifact.java
Outdated
Show resolved
Hide resolved
subprojects/plugins/src/main/java/org/gradle/api/plugins/internal/JvmPluginsHelper.java
Outdated
Show resolved
Hide resolved
This gives us many of these conversions for free, reducing duplicated code. This also fixes #15711.
octylFractal
force-pushed
the
ot/bugfix/provider-for-publish-artifact
branch
from
51dde6a
to
8a32350
Compare
big-guy
approved these changes
Nov 11, 2021
bot-gradle
added a commit
that referenced
this pull request
Dec 16, 2021
|
OK, I've already triggered a build for you. |
|
Pre-tested commit build failed. |
|
@bot-gradle test and merge |
|
OK, I've already triggered a build for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us many of these conversions for free, reducing duplicated code. This also fixes #15711.
The bulk of the change is
LazyPublishArtifact.java, everything else is dependency injection or test fixing.