New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Previous Test Options Behavior (for Release Branch) #19087
Merged
bot-gradle
merged 13 commits into
release
from
tt/74/release-restore-previous-test-options-behavior
Nov 24, 2021
Merged
Restore Previous Test Options Behavior (for Release Branch) #19087
bot-gradle
merged 13 commits into
release
from
tt/74/release-restore-previous-test-options-behavior
Nov 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… accessed prior to test framework selection.
…s force test re-running.
…from a TestSuite even when that property is queried multiple times.
… and expect new deprecation warning to fix broken tests.
… in suites consistently.
…il everywhere without these assumptions.
…uccess/failure locally here, as on CI.
Ignore the 74 in the branch naming, it should be 731. |
ljacomet
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One thing is to fix the test failures, see below:
...ting-jvm/src/integTest/groovy/org/gradle/testing/testsuites/TestSuitesIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
@bot-gradle test this |
OK, I've already triggered ReadyForMerge build for you. |
@bot-gradle test and merge |
OK, I've already triggered a build for you. |
blindpirate
deleted the
tt/74/release-restore-previous-test-options-behavior
branch
November 30, 2021 01:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19058
Context
This is a continuation of this PR, with the work rebased against the release branch. Please see that PR for many explanatory comments.