Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Previous Test Options Behavior (for Release Branch) #19087

Merged

Conversation

tresat
Copy link
Member

@tresat tresat commented Nov 23, 2021

Fixes #19058

Context

This is a continuation of this PR, with the work rebased against the release branch. Please see that PR for many explanatory comments.

@tresat tresat requested a review from a team as a code owner November 23, 2021 13:14
@bot-gradle bot-gradle added this to the 7.3.1 milestone Nov 23, 2021
@tresat tresat removed the request for review from a team November 23, 2021 13:14
@tresat
Copy link
Member Author

tresat commented Nov 23, 2021

Ignore the 74 in the branch naming, it should be 731.

@tresat tresat linked an issue Nov 23, 2021 that may be closed by this pull request
Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One thing is to fix the test failures, see below:

@tresat
Copy link
Member Author

tresat commented Nov 23, 2021

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

OK, I've already triggered ReadyForMerge build for you.

@tresat
Copy link
Member Author

tresat commented Nov 24, 2021

@bot-gradle test and merge

@gradle gradle deleted a comment from tresat Nov 24, 2021
@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

@bot-gradle bot-gradle merged commit 86988ab into release Nov 24, 2021
@blindpirate blindpirate deleted the tt/74/release-restore-previous-test-options-behavior branch November 30, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider reverting breaking change about test configuration
3 participants