Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing test options no longer warns, but locks in test framework selection #21750

Closed
wants to merge 19 commits into from

Commits on Aug 30, 2022

  1. Configuration menu
    Copy the full SHA
    16dd9e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Clean style violations

    tresat committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    22dfccb View commit details
    Browse the repository at this point in the history
  2. Correct name of test method

    tresat committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    899903b View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Update error message format when attempting to improperly set test fr…

    …amework after options are already set
    
    - Also provide each test framework with a display name property for user-facing references.
    tresat committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    45363ed View commit details
    Browse the repository at this point in the history
  2. Optimize framework creation now that reseting framework after options…

    … set is blocked elsewhere
    tresat committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    1f54a04 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    50a4758 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Restore map lookup functionality which is needed

    - Add comment explaining why.
    - Add tests to ensure behavior remains correct.
    tresat committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    d21e077 View commit details
    Browse the repository at this point in the history
  2. Remove unused field

    tresat committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    2ec207e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b2e1fdb View commit details
    Browse the repository at this point in the history
  4. Expose a property from the Test task to check if options are already …

    …accessed; check this when changing framework in a suite
    
    - We need to check not just when changing the test framework within a test task, but when changing the test framework for a suite
    if the associated test tasks for that suite have had options accessed.  Otherwise, the test task will silently continue to use the options
    and framework first configured without switching to the new ones.
    - Create new test class to demonstrate misconfigurations of options.
    tresat committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    3be7020 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Update test expectations now that reseting options fails fast

    - Consolidate options-related tests.
    tresat committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    86995a2 View commit details
    Browse the repository at this point in the history
  2. Clarify tests

    - Remove margin bar in multiline strings.
    - Make naming of migrated method consistent.
    - Remove extraneous comments.
    tresat committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    2624e9b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eb633d7 View commit details
    Browse the repository at this point in the history
  4. Also test excluding categories

    tresat committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    9441e5e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    467f607 View commit details
    Browse the repository at this point in the history
  6. Remove unused imports

    tresat committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    aa64e52 View commit details
    Browse the repository at this point in the history
  7. Print name of test framework the user is attempting to set in test su…

    …ite in error message if attempt fails due to test options already being accessed
    tresat committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    8360456 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Merge branch 'master' into tt/80/deprecations/use-test-framework

    # Conflicts:
    #	subprojects/plugins/src/main/java/org/gradle/api/plugins/jvm/internal/DefaultJvmTestSuite.java
    #	subprojects/testing-jvm/src/main/java/org/gradle/api/internal/tasks/testing/TestFramework.java
    #	subprojects/testing-jvm/src/main/java/org/gradle/api/internal/tasks/testing/junit/JUnitTestFramework.java
    #	subprojects/testing-jvm/src/main/java/org/gradle/api/internal/tasks/testing/junitplatform/JUnitPlatformTestFramework.java
    #	subprojects/testing-jvm/src/main/java/org/gradle/api/internal/tasks/testing/testng/TestNGTestFramework.java
    tresat committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    d501ea3 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. Configuration menu
    Copy the full SHA
    2ccafe8 View commit details
    Browse the repository at this point in the history