Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Kotlin MPP plugin #23026

Closed
wants to merge 1 commit into from

Conversation

donat
Copy link
Member

@donat donat commented Dec 7, 2022

The Kotlin team reported that Gradle 7.6 broke the Kotlin MPP plugin. The root cause is a change in an internal TestResultProcessor class that is used by the plugin.

This PR restores compatibility by reverting the changes to the TestResultProcessor. More specifically, merging this PR would result in the following changes over the Gradle versions:

  • Gradle 7.5: TestResultProcessor.failure(Object id, Throwable failure)
  • Gradle 7.6: TestResultProcessor.failure(Object id, TestFailure failure)
  • Gradle 7.6.1: TestResultProcessor.failure(Object id, Throwable failure)

Also, to preserve functionality, this PR makes TestFailure a subclass of Throwable.

@donat
Copy link
Member Author

donat commented Dec 7, 2022

@bot-gradle test RFM

@bot-gradle
Copy link
Collaborator

OK, I've already triggered the following builds for you:

@donat donat added this to the 7.6.1 milestone Dec 7, 2022
@donat donat closed this Dec 8, 2022
@donat donat deleted the donat/testlauncher/kotlin-mpp-compat-2 branch December 8, 2022 10:06
@ov7a ov7a removed this from the 7.6.1 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants