New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not expose named domain object list #23050
Merged
bot-gradle
merged 5 commits into
release
from
jbartok/do-not-expose-named-domain-object-list
Dec 9, 2022
Merged
Do not expose named domain object list #23050
bot-gradle
merged 5 commits into
release
from
jbartok/do-not-expose-named-domain-object-list
Dec 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvandort
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than some necessary updates in accepted-public-api-changes.json
...vm/src/main/java/org/gradle/jvm/toolchain/internal/DefaultJavaToolchainResolverRegistry.java
Outdated
Show resolved
Hide resolved
jbartok
force-pushed
the
jbartok/do-not-expose-named-domain-object-list
branch
from
December 9, 2022 11:13
90b60d6
to
8f0919c
Compare
…n/internal/DefaultJavaToolchainResolverRegistry.java Co-authored-by: Justin Van Dort <jvandort@gradle.com>
@bot-gradle test this |
OK, I've already triggered the following builds for you: |
@bot-gradle test and merge |
Your PR is queued. See the queue page for details. |
OK, I've already triggered a build for you. |
jbartok
added a commit
that referenced
this pull request
Dec 14, 2022
big-guy
added a commit
that referenced
this pull request
Dec 20, 2022
* origin/release7x: Fix issue with ant builder throwing exception on call() Ignore failing M9JavaConfigurabilityCrossVersionSpec on Gradle 2.x Revert some unnecessary changes Reformat to one sentence per line Fix deprecation message Fix test Do not expose named domain object list (backport #23050 & #23112) Remove exceptional M1 Mac toolchain handling Fix test Consider IBM and IBM_SEMERU vendors identical, deprecate the later Fix the issue of provisioning the same toolchain multiple times (backport #23024) Check Java Toolchain install folder for left-overs (backport #22819) Remove cygwin gcc Prepare for 7.6.1 release Fix upgrade note following Groovy update Attempt to reduce GC pressure by not holding expensive this references in ThreadLocals Refactor ArtifactSelector to avoid capturing the full component metadata in the lambda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23016