Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle inconsistent vendor info for IBM Semeru runtimes #23075

Merged
merged 6 commits into from Dec 14, 2022
Merged

Handle inconsistent vendor info for IBM Semeru runtimes #23075

merged 6 commits into from Dec 14, 2022

Conversation

jbartok
Copy link
Member

@jbartok jbartok commented Dec 9, 2022

Fixes #23053

@jbartok jbartok added this to the 8.0 RC1 milestone Dec 9, 2022
@jbartok jbartok self-assigned this Dec 9, 2022
@jbartok jbartok requested a review from ljacomet December 9, 2022 13:18
@jbartok jbartok added the in:toolchains Java Toolchains label Dec 9, 2022
@jbartok jbartok mentioned this pull request Dec 9, 2022
Closed
@jbartok jbartok changed the title Work around bad vendor info for IBM Semeru runtimes Handle inconsistent vendor info for IBM Semeru runtimes Dec 10, 2022
@jbartok jbartok force-pushed the jbartok/fix-ibm-semeru-vendor-metadata branch from d810b20 to 4ea8d82 Compare December 11, 2022 19:00
@gradle gradle deleted a comment from jbartok Dec 11, 2022
@gradle gradle deleted a comment from jbartok Dec 12, 2022
@gradle gradle deleted a comment from jbartok Dec 12, 2022
@gradle gradle deleted a comment from jbartok Dec 12, 2022
@jbartok jbartok force-pushed the jbartok/fix-ibm-semeru-vendor-metadata branch from 4ea8d82 to 5621296 Compare December 12, 2022 11:14
@jbartok jbartok marked this pull request as ready for review December 12, 2022 11:15
@jbartok jbartok requested a review from a team as a code owner December 12, 2022 11:15
@jbartok jbartok requested a review from tresat December 12, 2022 11:15
@jbartok
Copy link
Member Author

jbartok commented Dec 12, 2022

Extra manual tests: toolchain auto provisioning works fine end-to-end for all combinations of:

  • vendor: IBM, IBM_SEMERU
  • implementation: unspecified, J9
  • java: 8, 11, 16, 17

@jbartok
Copy link
Member Author

jbartok commented Dec 12, 2022

@bot-gradle test this

@gradle gradle deleted a comment from jbartok Dec 12, 2022
@bot-gradle
Copy link
Collaborator

OK, I've already triggered the following builds for you:

ljacomet
ljacomet approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

One comment to address before merging is the javadoc for IBM_SEMERU, see below

subprojects/docs/src/docs/userguide/migration/upgrading_version_7.adoc Outdated Show resolved Hide resolved
subprojects/platform-jvm/src/main/java/org/gradle/jvm/toolchain/JvmVendorSpec.java Show resolved Hide resolved
subprojects/platform-jvm/src/main/java/org/gradle/jvm/toolchain/JvmVendorSpec.java Outdated Show resolved Hide resolved
@jbartok
Copy link
Member Author

jbartok commented Dec 14, 2022

@bot-gradle test and merge

@gradle gradle deleted a comment from jbartok Dec 14, 2022
@bot-gradle
Copy link
Collaborator

Your PR is queued. See the queue page for details.

@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

@bot-gradle bot-gradle merged commit 7d72bae into release Dec 14, 2022
@jbartok jbartok deleted the jbartok/fix-ibm-semeru-vendor-metadata branch December 14, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tresat tresat tresat approved these changes

@ljacomet ljacomet ljacomet approved these changes

Assignees

@jbartok jbartok

Labels
in:toolchains Java Toolchains
Projects
None yet
Milestone
8.0 RC1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbartok @bot-gradle @tresat @ljacomet