Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle inconsistent vendor info for IBM Semeru runtimes (backport) #23094

Merged
merged 4 commits into from Dec 15, 2022

Conversation

jbartok
Copy link
Member

@jbartok jbartok commented Dec 10, 2022

Fixes #23053

It doesn't make sense to have both the IBM and IBM_SEMERU vendor values.

@jbartok jbartok self-assigned this Dec 10, 2022
@jbartok jbartok added the in:toolchains Java Toolchains label Dec 10, 2022
@jbartok jbartok added this to the 7.6.1 milestone Dec 10, 2022
@jbartok jbartok changed the title Remove IBM_SEMERU vendor Remove IBM_SEMERU vendor (backport) Dec 10, 2022
@jbartok jbartok changed the title Remove IBM_SEMERU vendor (backport) Handle inconsistent vendor info for IBM Semeru runtimes (backport) Dec 10, 2022
Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix the vendor matching string for IBM and IBM_SEMERU so that current use cases work and then deprecate IBM_SEMERU.
But I do not think we should remove it altogether without a deprecation.

@gradle gradle deleted a comment from jbartok Dec 12, 2022
@gradle gradle deleted a comment from jbartok Dec 12, 2022
@jbartok jbartok force-pushed the jbartok/get-rid-of-ibm-semeru branch from dd80e4a to 0a7f478 Compare December 12, 2022 12:52
@jbartok jbartok marked this pull request as ready for review December 12, 2022 12:52
@gradle gradle deleted a comment from jbartok Dec 12, 2022
@gradle gradle deleted a comment from blindpirate Dec 12, 2022
@gradle gradle deleted a comment from jbartok Dec 13, 2022
@gradle gradle deleted a comment from jbartok Dec 14, 2022
@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

@bot-gradle
Copy link
Collaborator

Pre-tested commit build failed.

@blindpirate
Copy link
Collaborator

@bot-gradle test and merge

@gradle gradle deleted a comment from jbartok Dec 15, 2022
@gradle gradle deleted a comment from jbartok Dec 15, 2022
@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

@bot-gradle bot-gradle merged commit d35a7c7 into release7x Dec 15, 2022
@blindpirate blindpirate deleted the jbartok/get-rid-of-ibm-semeru branch December 15, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:toolchains Java Toolchains
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants