Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expose named domain object list, take 2 #23112

Merged
merged 7 commits into from Dec 14, 2022

Conversation

jbartok
Copy link
Member

@jbartok jbartok commented Dec 12, 2022

Fixes #23016

@jbartok jbartok added the in:toolchains Java Toolchains label Dec 12, 2022
@jbartok jbartok added this to the 8.0 RC1 milestone Dec 12, 2022
@jbartok jbartok requested a review from a team as a code owner December 12, 2022 09:28
@jbartok jbartok self-assigned this Dec 12, 2022
@jbartok jbartok changed the base branch from master to release December 12, 2022 09:28
Copy link
Member

@jvandort jvandort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple comments

Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes in the right direction.

A few remarks though:

@jbartok
Copy link
Member Author

jbartok commented Dec 14, 2022

@bot-gradle test this

@gradle gradle deleted a comment from jbartok Dec 14, 2022
@bot-gradle
Copy link
Collaborator

OK, I've already triggered the following builds for you:

Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jbartok
Copy link
Member Author

jbartok commented Dec 14, 2022

@bot-gradle test and merge

@gradle gradle deleted a comment from jbartok Dec 14, 2022
@bot-gradle
Copy link
Collaborator

Your PR is queued. See the queue page for details.

@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

@bot-gradle bot-gradle merged commit 33f1620 into release Dec 14, 2022
@jbartok jbartok deleted the jbartok/do-not-expose-named-domain-object-list branch December 14, 2022 17:52
big-guy added a commit that referenced this pull request Dec 20, 2022
* origin/release7x:
  Fix issue with ant builder throwing exception on call()
  Ignore failing M9JavaConfigurabilityCrossVersionSpec on Gradle 2.x
  Revert some unnecessary changes
  Reformat to one sentence per line
  Fix deprecation message
  Fix test
  Do not expose named domain object list (backport #23050 & #23112)
  Remove exceptional M1 Mac toolchain handling
  Fix test
  Consider IBM and IBM_SEMERU vendors identical, deprecate the later
  Fix the issue of provisioning the same toolchain multiple times (backport #23024)
  Check Java Toolchain install folder for left-overs (backport #22819)
  Remove cygwin gcc
  Prepare for 7.6.1 release
  Fix upgrade note following Groovy update
  Attempt to reduce GC pressure by not holding expensive this references in ThreadLocals
  Refactor ArtifactSelector to avoid capturing the full component metadata in the lambda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:toolchains Java Toolchains
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toolchainManagement.jvm.javaRepositories should not expose the full surface of NamedDomainObjectList
4 participants