New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not expose named domain object list, take 2 #23112
Do not expose named domain object list, take 2 #23112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a couple comments
subprojects/core/src/main/java/org/gradle/internal/FinalizableValue.java
Outdated
Show resolved
Hide resolved
...m/src/main/java/org/gradle/jvm/toolchain/internal/DefaultJavaToolchainRepositoryHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This goes in the right direction.
A few remarks though:
...m/src/main/java/org/gradle/jvm/toolchain/internal/DefaultJavaToolchainRepositoryHandler.java
Outdated
Show resolved
Hide resolved
subprojects/core/src/main/java/org/gradle/internal/FinalizableValue.java
Outdated
Show resolved
Hide resolved
subprojects/core/src/main/java/org/gradle/initialization/DefaultSettings.java
Outdated
Show resolved
Hide resolved
subprojects/core/src/main/java/org/gradle/initialization/DefaultSettings.java
Outdated
Show resolved
Hide resolved
@bot-gradle test this |
OK, I've already triggered the following builds for you: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@bot-gradle test and merge |
Your PR is queued. See the queue page for details. |
OK, I've already triggered a build for you. |
* origin/release7x: Fix issue with ant builder throwing exception on call() Ignore failing M9JavaConfigurabilityCrossVersionSpec on Gradle 2.x Revert some unnecessary changes Reformat to one sentence per line Fix deprecation message Fix test Do not expose named domain object list (backport #23050 & #23112) Remove exceptional M1 Mac toolchain handling Fix test Consider IBM and IBM_SEMERU vendors identical, deprecate the later Fix the issue of provisioning the same toolchain multiple times (backport #23024) Check Java Toolchain install folder for left-overs (backport #22819) Remove cygwin gcc Prepare for 7.6.1 release Fix upgrade note following Groovy update Attempt to reduce GC pressure by not holding expensive this references in ThreadLocals Refactor ArtifactSelector to avoid capturing the full component metadata in the lambda
Fixes #23016