Inject services into MinimalExternalModuleDependency instances #23232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvandort
force-pushed
the
jvandort/iss/23096/release7x/fix
branch
from
75d1e47
to
b877054
Compare
…y are created initially
jvandort
force-pushed
the
jvandort/iss/23096/release7x/fix
branch
from
b877054
to
4fed83e
Compare
|
@bot-gradle test this |
|
OK, I've already triggered the following builds for you: |
jvandort
changed the title
big-guy
approved these changes
Dec 20, 2022
|
@bot-gradle test and merge |
|
Your PR is queued. See the queue page for details. |
|
OK, I've already triggered a build for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23096
All dependencies which extend
AbstractModuleDependencyshould have theirattributesFactoryandcapabilityNotationParserinitialized. This is usually done in theDefaultDependencyFactory, though now thatMinimalExternalModuleDependencyextendsExternalModuleDependencyand its implements extendAbstractModuleDependency, we must be sure that we initialize its services when we instantiate them. This PR does that.Further, we ensure we properly copy all fields in instances of
MinimalExternalModuleDependencywhen copying them. This ensures we do not leave behind dependency artifacts or other data when adding dependencies to configurations via the projectDependencyHandler.