Ensure all version catalog dependency properties are copied #23246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvandort
changed the title
jvandort
force-pushed
the
jvandort/iss/23096/release7x/ensure-all-properties-are-copied
branch
2 times, most recently
from
314a24b
to
729a325
Compare
jvandort
force-pushed
the
jvandort/iss/23096/release7x/ensure-all-properties-are-copied
branch
4 times, most recently
from
6df8e55
to
ee87bfe
Compare
|
Reverted the I wrote up an issue to resolve the remaining two uncopied properties in 8.1: |
jvandort
force-pushed
the
jvandort/iss/23096/release7x/ensure-all-properties-are-copied
branch
from
ee87bfe
to
833cfab
Compare
big-guy
requested changes
Dec 23, 2022
...t/groovy/org/gradle/integtests/resolve/catalog/VersionCatalogExtensionIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
Follow up for #23096 to ensure all properties are properly copied
Even though these are desired changes, we are choosing to back them out of 7.6.1 as they are technically behavior changes and do not resolve an immediate 7.6 regression.
jvandort
force-pushed
the
jvandort/iss/23096/release7x/ensure-all-properties-are-copied
branch
from
833cfab
to
10086f7
Compare
|
@bot-gradle test this |
|
I've triggered the following builds for you: |
|
@bot-gradle test and merge |
|
I've triggered a build for you. |
bot-gradle
deleted the
jvandort/iss/23096/release7x/ensure-all-properties-are-copied
branch
bot-gradle
added a commit
that referenced
this pull request
Dec 27, 2022
Ensures the 7.6 regression fixed in #23246 is included in 8.0 Co-authored-by: Justin Van Dort <jvandort@gradle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #23096 with a more comprehensive test.
Ensures
targetConfigurationis copied when version catalog dependencies are copied. This property was copied pre7.6but regressed in7.6.While fixing this bug, I discovered
endorsingandversionConstraint.branchwere also not copied. We are leaving those fixes out of this PR but will fix in8.1. See: #23286