Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject services into all external module dependencies created by DefultJvmComponentDependencies #23535

Merged
merged 2 commits into from Jan 13, 2023
Merged

Inject services into all external module dependencies created by DefultJvmComponentDependencies #23535

merged 2 commits into from Jan 13, 2023

Conversation

tresat
Copy link
Member

@tresat tresat commented Jan 13, 2023

This fixes an issue where you can decorate a dep with platform and get a runtime failure because an AttributesFactory
has not been injected into the dep.

Fixes #19065

@tresat
Inject services into all external module dependencies created by Defa…
cadc7f6 
…ultJvmComponentDependencies

This fixes an issue where you can decorate a dep with platform and get a runtime failure because an AttributesFactory
has not been injected into the dep.
@tresat
ServiceInject project dependencies for consistency
e9f1eb3 
- Adds integration tests for test suites using project coordinate dependencies to ensure this remains working
@tresat
Copy link
Member Author

tresat commented Jan 13, 2023

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you:

@tresat tresat mentioned this pull request Jan 13, 2023
Closed
@tresat tresat linked an issue Jan 13, 2023 that may be closed by this pull request
Platform dependencies not possible in dependency block of test suite plugin #19065
Closed
@tresat tresat self-assigned this Jan 13, 2023
@tresat tresat added this to the 7.6.1 milestone Jan 13, 2023
@tresat tresat added the in:test-suites Work related to the JvmTestSuite Plugin label Jan 13, 2023
@tresat
Copy link
Member Author

tresat commented Jan 13, 2023

@octylFractal - This ensures project dependencies also had services injects. This is the only other type extending AbstractModuleDependency created by the new code paths in the factory from the test suites' dependencies block. This was not currently broken, but I added the injection logic and some tests referencing projects by coordinates to be comprehensive. Version catalog dependencies are not created by this factory, so they should be fine and the existing DSL integration tests which exercise them with test suites (TestSuitesGroovyDSLDependenciesIntegrationTest) should be sufficient.

@tresat tresat mentioned this pull request Jan 13, 2023
Closed
@tresat
Copy link
Member Author

tresat commented Jan 13, 2023

@bot-gradle test and merge

@bot-gradle
Copy link
Collaborator

I've triggered a build for you.

@bot-gradle bot-gradle merged commit 590345d into release7x Jan 13, 2023
@bot-gradle bot-gradle deleted the tt/7x/test-suites-dependency-modifiers branch January 13, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octylFractal octylFractal octylFractal approved these changes

Assignees

@tresat tresat

Labels
in:test-suites Work related to the JvmTestSuite Plugin
Projects
None yet
Milestone
7.6.1
Development

Successfully merging this pull request may close these issues.

Platform dependencies not possible in dependency block of test suite plugin
3 participants
@tresat @bot-gradle @octylFractal