Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear root metadata when adding or removing configurations #23991

Merged
merged 1 commit into from Feb 23, 2023
Merged

Clear root metadata when adding or removing configurations #23991

merged 1 commit into from Feb 23, 2023

Conversation

jvandort
Copy link
Member

This ensures when a configuration is removed and added between resolutions, we can clear and subsequently re-calculate updated metadata

Fixes #23985

@jvandort jvandort force-pushed the jvandort/76/clear-root-metadata-when-adding-and-removing-configurations branch 2 times, most recently from 803c598 to 557740f Compare February 21, 2023 23:36
@jvandort jvandort self-assigned this Feb 21, 2023
@jvandort jvandort added this to the 7.6.1 milestone Feb 21, 2023
@jvandort jvandort added the a:regression This used to work label Feb 21, 2023
@jvandort
Clear root metadata when adding or removing configurations
9754d4e 
This ensures when a configuration is removed and added between resolutions, we can clear and subsequently re-calculate updated metadata
@jvandort jvandort force-pushed the jvandort/76/clear-root-metadata-when-adding-and-removing-configurations branch from 557740f to 9754d4e Compare February 21, 2023 23:55
@jvandort jvandort marked this pull request as ready for review February 22, 2023 12:45
@jvandort jvandort requested review from big-guy, ljacomet and a team February 22, 2023 12:45
@ljacomet
Copy link
Member

@bot-gradle test RfR

@gradle gradle deleted a comment from jvandort Feb 23, 2023
@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you:

@ljacomet
Copy link
Member

@bot-gradle test and merge

@gradle gradle deleted a comment from jvandort Feb 23, 2023
@bot-gradle
Copy link
Collaborator

Your PR is queued. See the queue page for details.

@bot-gradle
Copy link
Collaborator

I've triggered a build for you.

@bot-gradle bot-gradle merged commit 87bcc57 into release7x Feb 23, 2023
@bot-gradle bot-gradle deleted the jvandort/76/clear-root-metadata-when-adding-and-removing-configurations branch February 23, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljacomet ljacomet ljacomet approved these changes

@big-guy big-guy big-guy approved these changes

Assignees

@jvandort jvandort

Labels
a:regression This used to work
Projects
None yet
Milestone
7.6.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jvandort @ljacomet @bot-gradle @big-guy