Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump default daemon max metaspace to 384m #24080

Merged
merged 1 commit into from Mar 1, 2023
Merged

Bump default daemon max metaspace to 384m #24080

merged 1 commit into from Mar 1, 2023

Conversation

eskatos
Copy link
Member

@eskatos eskatos commented Feb 28, 2023

In Gradle 8.0 we got closer to the previous limit in reasonable scenarios. Scenarios involving Kotlin compilation now require more metaspace with Kotlin 1.8.

@eskatos
Bump default daemon max metaspace to 384m
a9eabdc 
In Gradle 8.0 we got closer to the previous limit in reasonable scenarios.
Scenarios involving Kotlin compilation now require more metaspace with Kotlin 1.8.
@eskatos eskatos added this to the 8.0.2 (unconfirmed) milestone Feb 28, 2023
@eskatos eskatos self-assigned this Feb 28, 2023
@eskatos
Copy link
Member Author

eskatos commented Feb 28, 2023

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you:

@eskatos eskatos marked this pull request as ready for review February 28, 2023 17:44
@eskatos eskatos requested a review from a team February 28, 2023 17:48
@TWiStErRob TWiStErRob mentioned this pull request Feb 28, 2023
Closed
ljacomet
ljacomet approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense as an immediate solution. I hope we can improve the situation later on and go back to the previous default.

@ljacomet
Copy link
Member

ljacomet commented Mar 1, 2023

@bot-gradle test and merge

@bot-gradle
Copy link
Collaborator

I've triggered a build for you.

@ljacomet ljacomet linked an issue Mar 1, 2023 that may be closed by this pull request
Gradle 8 RC2 runs out of metaspace #23698
Closed
@bot-gradle bot-gradle merged commit dbe9d34 into release Mar 1, 2023
@bot-gradle bot-gradle deleted the eskatos/daemon/larger-metaspace-default branch March 1, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljacomet ljacomet ljacomet approved these changes

Assignees

@eskatos eskatos

Labels
in:daemon
Projects
None yet
Milestone
8.0.2
Development

Successfully merging this pull request may close these issues.

Gradle 8 RC2 runs out of metaspace
3 participants
@eskatos @bot-gradle @ljacomet