Clear root metadata when extending configurations #24118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljacomet
approved these changes
Mar 2, 2023
The hierarchy is saved as an instance variable in configuration metadata. The mutation type for configuration extension was DEPENDENCIES, which only caused the cached metadata to be reevaluated. This is not sufficient. We add a new mutation type for HIERARCHY which completely discards the metadata, allowing it to be recalculated and the new hierarchy value to be passed to the configuration metadata
jvandort
force-pushed
the
jvandort/iss/24109/clear-metadata-upon-configuration-extension
branch
from
9542517
to
8fcba91
Compare
|
@bot-gradle test this |
|
I've triggered the following builds for you: |
tresat
approved these changes
Mar 2, 2023
...internal/artifacts/ivyservice/moduleconverter/DefaultRootComponentMetadataBuilderTest.groovy
Show resolved
Hide resolved
...gTest/groovy/org/gradle/integtests/resolve/api/ExtendingConfigurationsIntegrationTest.groovy
Show resolved
Hide resolved
|
@bot-gradle test and merge |
|
I've triggered a build for you. |
bot-gradle
deleted the
jvandort/iss/24109/clear-metadata-upon-configuration-extension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hierarchy is saved as an instance variable in configuration metadata. The mutation type for configuration extension
was DEPENDENCIES, which only caused the cached metadata to be reevaluated. This is not sufficient. We add a new mutation
type for HIERARCHY which completely discards the metadata, allowing it to be recalculated and the new hierarchy value
to be passed to the configuration metadata
Fixes #24109