Run dependency actions on entire hierarchy #24280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cies Make sure we run the dependency actions on the entire hierarchy before traversing that hierarchy for dependencies and excludes. This is because the dependency actions may themselves modify the hierarchy, so before traversing we need to make sure the hierarchy isn't going to change out from under us. This should be fine since configurations' dependency actions are idempotent. The actions automatically de-register themselves, so once they're called, they're not triggered for subsequent calls.
jvandort
force-pushed
the
jvandort/iss/24234/run-dependency-actions-on-entire-hierarchy
branch
from
c4fdb51
to
4694d35
Compare
|
@bot-gradle test this |
|
I've triggered the following builds for you: |
octylFractal
approved these changes
Mar 13, 2023
|
@bot-gradle test and merge |
|
I've triggered a build for you. |
bot-gradle
deleted the
jvandort/iss/24234/run-dependency-actions-on-entire-hierarchy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we run the dependency actions on the entire hierarchy before traversing that hierarchy for dependencies and excludes. This is because the dependency actions may themselves modify the hierarchy, so before traversing we need to make sure the hierarchy isn't going to change out from under us.
This should be fine since configurations' dependency actions are idempotent. The actions automatically de-register themselves, so once they're called, they're not triggered for subsequent calls.
Fixes: #24234