New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kotlin-dsl): unable to use events = setOf()
in testLogging
#28798
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Nils Brugger <nilsbrugger.nb.nb.nb@gmail.com>
Thank you for your contribution! Can you please add some tests to demonstrate and cover your changes? Is there any particular scenario you are looking to support? |
Added a unit test. The reason one wants to set an empty PS: sorry for the delayed answer |
Change SummaryThis PR is 85.71% new code.
|
Signed-off-by: Nils Brugger <nilsbrugger.nb.nb.nb@gmail.com>
@bot-gradle test and merge |
The merge queue build has failed. Click here to see all failures. |
Context
It fixes a bug that prevents to use
evennts = setOf()
which would be the natural approach for Kotlin DSL. (since EnumSet.of() throws an exception on empty sets)Contributor Checklist
<subproject>/src/integTest
) to verify changes from a user perspective.<subproject>/src/test
) to verify logic../gradlew sanityCheck
../gradlew <changed-subproject>:quickTest
.Reviewing cheatsheet
Before merging the PR, comments starting with