Fix error prone warnings in :core-execution #28819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lptr
added
a:chore
asodja
approved these changes
Apr 15, 2024
asodja
reviewed
Apr 15, 2024
reinsch82
reviewed
Apr 22, 2024
| @@ -72,11 +64,6 @@ public ImmutableList<String> getChangeDescriptions() { | |||
| public InputChangesInternal createInputChanges() { | |||
| return new NonIncrementalInputChanges(beforeExecutionState.getInputFileProperties(), incrementalInputProperties); | |||
| } | |||
|
|
|||
| @Override | |||
| public BeforeExecutionState getBeforeExecutionState() { | |||
There was a problem hiding this comment.
👍 I love how code evaporates
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
lptr
force-pushed
the
lptr/execution/fix-error-prone-warnings
branch
from
b4d6a7c
to
9ffa942
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
The merge queue build has failed. Click here to see all failures. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The merge queue build has failed. Click here to see all failures. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@bot-gradle merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing cheatsheet
Before merging the PR, comments starting with