Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some ErrorProne issues in :model-core #28892

Merged
merged 12 commits into from
May 8, 2024
Merged

Fix some ErrorProne issues in :model-core #28892

merged 12 commits into from
May 8, 2024

Commits on May 6, 2024

  1. Fix "FormatString" warnings in :model-core

    @mlopatkin
    mlopatkin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    063b470 View commit details
    Browse the repository at this point in the history

  2. Fix "EmptyBlockTag" warnings in :model-core

    @mlopatkin
    mlopatkin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    fdf3a69 View commit details
    Browse the repository at this point in the history

  3. Fix "HidingField" warnings in :model-core

    @mlopatkin
    mlopatkin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2aee4e6 View commit details
    Browse the repository at this point in the history

  4. Fix "InvalidParam" warnings in :model-core

    @mlopatkin
    mlopatkin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    afc7f2b View commit details
    Browse the repository at this point in the history

  5. Fix "TypeParameterShadowing" warnings in :model-core

    @mlopatkin
    mlopatkin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    408938b View commit details
    Browse the repository at this point in the history

  6. Fix "UnusedTypeParameter" warnings in :model-core

    @mlopatkin
    mlopatkin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    fc4ac38 View commit details
    Browse the repository at this point in the history

  7. Fix "StringCaseLocaleUsage" warnings in :model-core

    @mlopatkin
    mlopatkin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    ca0bdcf View commit details
    Browse the repository at this point in the history

  8. Don't actually lowercase key type of the MapProperty 

    The type is user-provided and may contain non-ASCII symbols, or the
default locale might have surprising case conversion rules (e.g.
`I -> ı` for the Turkish language).
    @mlopatkin
    mlopatkin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e163d00 View commit details
    Browse the repository at this point in the history

  9. Fix "IdentityHashMapUsage" warnings in :model-core

    @mlopatkin
    mlopatkin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    367afa2 View commit details
    Browse the repository at this point in the history

  10. Do not suppress "MutablePublicArray" warning in :model-core 

    The warning was fixed by some other commit.
    @mlopatkin
    mlopatkin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    c1678a0 View commit details
    Browse the repository at this point in the history

  11. Fix/suppress "MixedMutabilityReturnType" warnings in :model-core 

    The BeanDynamicObject use case doesn't have enough ROI to investigate
and fix properly, let's live with what we have. Both always returning
mutable and always returning immutable may break stuff.
    @mlopatkin
    mlopatkin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6e630b4 View commit details
    Browse the repository at this point in the history

  12. Fix "OperatorPrecedence" warnings in :model-core

    @mlopatkin
    mlopatkin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6533fa9 View commit details
    Browse the repository at this point in the history