Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle Toolchain remove PropertyOrigin.java and other cleanups #28911

Open
wants to merge 1 commit into
base: release
Choose a base branch
from

Conversation

vmadalin
Copy link
Contributor

After #28731 PR was merged a small clean up is required to remove unused variables, PropertyOrigin and also other warnings.

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

@vmadalin vmadalin requested review from a team as code owners April 22, 2024 14:30
@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Apr 22, 2024
@vmadalin vmadalin force-pushed the daemon-toolchain-build-options-clean-up branch 2 times, most recently from 0711934 to 1600d0d Compare April 22, 2024 14:48
@ov7a ov7a added 👋 team-triage Issues that need to be triaged by a specific team in:daemon and removed to-triage labels Apr 23, 2024
@big-guy big-guy added this to the 8.9 RC1 milestone Apr 23, 2024
@big-guy big-guy removed the 👋 team-triage Issues that need to be triaged by a specific team label Apr 23, 2024
@big-guy
Copy link
Member

big-guy commented Apr 23, 2024

Thanks, I'll take a look for 8.9

@vmadalin vmadalin changed the base branch from master to release April 28, 2024 21:34
Signed-off-by: Madalin Valceleanu <vmadalin@google.com>
@vmadalin vmadalin force-pushed the daemon-toolchain-build-options-clean-up branch from 1600d0d to f3a22da Compare April 28, 2024 21:42
Copy link

gitstream-cm bot commented Apr 28, 2024

Change Summary

This PR is 25.41% new code.
Platform Added Lines % of Total Line Changes Deleted Lines % of Total Line Changes Files Changed % of Total Files Changed
bt_ge_build_cache 0 0% 0 0% 0 0%
build_infrastructure 0 0% 0 0% 0 0%
core_configuration 0 0% 0 0% 0 0%
core_execution 31 25.41% 88 72.13% 12 85.71%
core_runtime 31 25.41% 88 72.13% 12 85.71%
documentation 0 0% 0 0% 0 0%
extensibility 0 0% 0 0% 0 0%
gradle_enterprise 0 0% 0 0% 0 0%
ide 0 0% 0 0% 0 0%
jvm 0 0% 0 0% 0 0%
kotlin_dsl 0 0% 0 0% 0 0%
release_coordination 0 0% 0 0% 0 0%
software 0 0% 0 0% 0 0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:contributor PR by an external contributor in:daemon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants