Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define vendor for the Daemon JVM criteria #28931

Open
wants to merge 1 commit into
base: release
Choose a base branch
from

Conversation

vmadalin
Copy link
Contributor

@vmadalin vmadalin commented Apr 23, 2024

Context

After #28731 PR was merged the initial vendor support was removed. This PR adds the support back by following the agreed public spec document but also the recent #28934 linked to the Daemon toolchain support.

Those are changes to add support for vendor on Daemon toolchain criteria:

  • Add JvmVendor on DaemonContext using systemProperties to obtain its value from running daemon process
  • Expose JvmVendorSpec property on UpdateDaemonJvm task by making the class serializable
  • Bypass daemon toolchain criteria if this is invalid when executing UpdateDaemonJvm task so it can still update the daemon-jvm properties file

## Demo

Daemon.toolchain.using.vendor.mov

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Apr 23, 2024
@vmadalin vmadalin force-pushed the daemon-toolchain-support-vendor branch from dfe38c3 to 6b25458 Compare April 23, 2024 14:10
@ov7a ov7a added in:daemon and removed to-triage labels Apr 23, 2024
@big-guy big-guy self-requested a review April 23, 2024 17:10
@big-guy big-guy added this to the 8.9 RC1 milestone Apr 23, 2024
@vmadalin vmadalin force-pushed the daemon-toolchain-support-vendor branch 2 times, most recently from aadea69 to 2dabac7 Compare May 1, 2024 11:39
@vmadalin vmadalin changed the base branch from master to release May 1, 2024 11:49
Signed-off-by: Madalin Valceleanu <vmadalin@google.com>
Copy link

gitstream-cm bot commented May 1, 2024

There are new TODOs present in this change. Should any be removed?

Copy link

gitstream-cm bot commented May 1, 2024

Change Summary

This PR is 75.59% new code.
Platform Added Lines % of Total Line Changes Deleted Lines % of Total Line Changes Files Changed % of Total Files Changed
bt_ge_build_cache 0 0% 0 0% 0 0%
build_infrastructure 0 0% 0 0% 0 0%
core_configuration 0 0% 0 0% 0 0%
core_execution 202 68.47% 57 19.32% 20 83.33%
core_runtime 202 68.47% 57 19.32% 20 83.33%
documentation 0 0% 0 0% 0 0%
extensibility 0 0% 0 0% 0 0%
gradle_enterprise 0 0% 0 0% 0 0%
ide 0 0% 0 0% 0 0%
jvm 8 2.71% 5 1.69% 3 12.5%
kotlin_dsl 0 0% 0 0% 0 0%
release_coordination 0 0% 0 0% 0 0%
software 0 0% 0 0% 0 0%

@vmadalin vmadalin marked this pull request as ready for review May 1, 2024 12:32
@vmadalin vmadalin requested review from a team as code owners May 1, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants