Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strong types for additional data in problem reports #28964

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

donat
Copy link
Member

@donat donat commented Apr 25, 2024

The internal Problems API allows clients to attach additional data. The data is currently stored in a map object. This pull request introduces strong, domain-specific types for the same data.

@gradle gradle deleted a comment from donat Apr 25, 2024
@donat donat force-pushed the donat/problems/strongly-typed-additional-data-2 branch from 88e9456 to d46e542 Compare April 25, 2024 12:13
@gradle gradle deleted a comment from donat Apr 25, 2024
@donat donat force-pushed the donat/problems/strongly-typed-additional-data-2 branch 2 times, most recently from 23c1a4c to 8629122 Compare April 26, 2024 13:39
@donat donat changed the title Donat/problems/strongly typed additional data 2 Introduce strong t Apr 26, 2024
@donat donat changed the title Introduce strong t Introduce strong types for InternalProblemSpec.additionalData() Apr 26, 2024
@gradle gradle deleted a comment from donat Apr 26, 2024
@donat donat force-pushed the donat/problems/strongly-typed-additional-data-2 branch from 8629122 to 8c46ac0 Compare May 2, 2024 07:31
@donat
Copy link
Member Author

donat commented May 2, 2024

@bot-gradle test QuickFeedbackLinux

@gradle gradle deleted a comment from donat May 2, 2024
@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@donat donat changed the title Introduce strong types for InternalProblemSpec.additionalData() Use strong types for additional data in problem reports May 2, 2024
@donat donat changed the title Use strong types for additional data in problem reports Use strong types for additional data in problem reports May 2, 2024
@donat donat changed the title Use strong types for additional data in problem reports Use strong types for additional data in problem reports May 2, 2024
@donat donat force-pushed the donat/problems/strongly-typed-additional-data-2 branch from 8c46ac0 to 6f51fd3 Compare May 2, 2024 08:04
@donat
Copy link
Member Author

donat commented May 2, 2024

@bot-gradle test QuickFeedbackLinux

@gradle gradle deleted a comment from donat May 2, 2024
@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@donat donat self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants