Add persistent cache for toolchain auto-detection mechanism #28966
+439
−115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
Daemon toolchain auto-detection mechanism
is part ofPhase 1
oftoolchain support for Gradle Daemon
, where the motivation behind it and other technical details can be found on the public spec document. This PR implements the persistent cache for the toolchain auto-detection mechanism by adding indexed cache on CachingJvmMetadataDetector storing the JvmInstallationMetadata resolved object based on toolchain installation path. This cache is a VersionStrategy.CachePerVersion allowing to have a separate cache instance for each Gradle version that are stored under Gradle User Home directory.Testing
Unit tests:
Integration tests
Demo
Simple demo exposing how persistent cache for toolchain auto-detection mechanism works:
Daemon.toolchain.auto-detection.cache.mov
Contributor Checklist
<subproject>/src/integTest
) to verify changes from a user perspective<subproject>/src/test
) to verify logic./gradlew sanityCheck
./gradlew <changed-subproject>:quickTest