New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If a variant cannot be selected because there are no variants, mentio… #28971
base: master
Are you sure you want to change the base?
Conversation
…n that instead of saying that every variant has no attributes Fixes: gradle#28970 Signed-off-by: Jeff Gaston <gastoj3@gmail.com>
Thank you for your contribution! This PR has a valid DCO and tests. The relevant team for this area will confirm the design of the implementation choices. |
@tresat will take a look |
- Clarify error message. - Use an IncompatibleGraphVariantFailure instead of ConfigurationNotFoundFailure, which fixes tests to pass by causing proper FailureDescriber to fire. - Add no variants exist failure demonstration to error showcase.
|
Thanks for submitting this @mathjeff! I think this is a good clarifying change to a possibly very confusing scenario. I made some adjustments to the way the failure is created that were necessary to make the test you submitted pass, and made some other minor changes. Assuming CI doesn't find any issues, I'll merge this for Gradle 8.9. |
Thanks! |
- This new message clarifies the situation in each of these cases.
@bot-gradle test and merge |
The merge queue build has failed. Click here to see all failures. |
@bot-gradle test and merge |
WARN: Based on labels, this pull request addresses notable issue but no changes to release note found. |
📊 Changes by Platform: this PR is 88% new code See details
|
The merge queue build has failed. Click here to see all failures. |
…n that
instead of saying that every variant has no attributes
Fixes: #28970
Context
Contributor Checklist
<subproject>/src/integTest
) to verify changes from a user perspective.<subproject>/src/test
) to verify logic../gradlew sanityCheck
../gradlew <changed-subproject>:quickTest
.Reviewing cheatsheet
Before merging the PR, comments starting with