Preserve old operation display names for backward compatibility with IntelliJ #28975
+86
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bot-gradle test ACT |
|
I've triggered the following builds for you. Click here to see all build failures. |
ov7a
force-pushed
the
ov7a/fix-operation-display-names-for-tests
branch
from
56f330c
to
87158e1
Compare
|
@bot-gradle test ACT |
|
I've triggered the following builds for you. Click here to see all build failures. |
MGaetan89
reviewed
Apr 26, 2024
Comment on lines
119
to
120
| * The problem only occurs in IntelliJ IDEA because it parses {@link OperationDescriptor#getDisplayName()} to get test display name. | ||
| * Once it's code is updated to use {@link org.gradle.tooling.events.test.TestOperationDescriptor#getTestDisplayName()}, the workaround can be removed as well. |
There was a problem hiding this comment.
Suggested change
| * The problem only occurs in IntelliJ IDEA because it parses {@link OperationDescriptor#getDisplayName()} to get test display name. | |
| * Once it's code is updated to use {@link org.gradle.tooling.events.test.TestOperationDescriptor#getTestDisplayName()}, the workaround can be removed as well. | |
| * The problem only occurs in IntelliJ IDEA because it parses {@link OperationDescriptor#getDisplayName()} to get the test display name. | |
| * Once its code is updated to use {@link org.gradle.tooling.events.test.TestOperationDescriptor#getTestDisplayName()}, the workaround can be removed as well. |
ov7a
force-pushed
the
ov7a/fix-operation-display-names-for-tests
branch
from
87158e1
to
0e67f27
Compare
donat
approved these changes
May 7, 2024
|
WARN: Based on labels, this pull request addresses notable issue but no changes to release note found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #24538 (comment)
Fixes #24538
Reviewing cheatsheet
Before merging the PR, comments starting with