Fix getClass on enum classes #28985
Merged
Fix getClass on enum classes #28985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlopatkin
requested review from
bamboo and
abstratt
and removed request for
a team
|
@bot-gradle test this |
|
I've triggered the following builds for you. Click here to see all build failures. |
bamboo
approved these changes
May 7, 2024
| @@ -367,6 +367,6 @@ class IsolatableSerializerRegistryTest extends Specification { | |||
| } | |||
|
|
|||
| enum EnumType { | |||
| FOO, BAR | |||
| FOO {}, BAR | |||
There was a problem hiding this comment.
❓ Is that enough to force a subtype? Perhaps adding a toString override might make the intention clearer
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Enum constants may be implemented as subclasses, so getClass may be unreliable, e.g. a subclass returns `false` from `isEnum`. This commit fixes a bunch of places where the invalid class was exposed.
bamboo
force-pushed
the
ml/fix-getclass-on-enum
branch
from
4b02fa0
to
ae3912d
Compare
|
@bot-gradle merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enum constants may be implemented as subclasses, so getClass may be
unreliable, e.g. a subclass returns
falsefromisEnum. This commitfixes a bunch of places where the invalid class was exposed.
Reviewing cheatsheet
Before merging the PR, comments starting with