Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing bullet list in 8.8 upgrade guide #28988

Merged
merged 1 commit into from Apr 29, 2024

Conversation

TWiStErRob
Copy link
Contributor

@TWiStErRob TWiStErRob commented Apr 27, 2024

Context

https://docs.gradle.org/8.8-rc-1/userguide/upgrading_version_8.html#changes_in_the_problems_api

image

From wording that seems to be a bullet list similar to others in the file.

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

Signed-off-by: Róbert Papp (TWiStErRob) <papp.robert.s@gmail.com>
@TWiStErRob TWiStErRob requested a review from a team as a code owner April 27, 2024 09:44
@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Apr 27, 2024
@TWiStErRob TWiStErRob changed the title Fix missing bullet list Fix missing bullet list in 8.8 upgrade guide Apr 27, 2024
@ov7a
Copy link
Member

ov7a commented Apr 29, 2024

Thanks!

@ov7a ov7a added this pull request to the merge queue Apr 29, 2024
@bot-gradle bot-gradle added this to the 8.9 RC1 milestone Apr 29, 2024
@ov7a ov7a added in:gradle-distribution gradle distribution content, size, bundled dependencies a:documentation Documentation content and removed to-triage labels Apr 29, 2024
@ov7a
Copy link
Member

ov7a commented Apr 29, 2024

@bot-gradle cherry-pick to release

@bot-gradle
Copy link
Collaborator

Currently I can only cherry-pick merged PR.

Merged via the queue into gradle:master with commit 0b9baf4 Apr 29, 2024
16 of 17 checks passed
@ov7a
Copy link
Member

ov7a commented Apr 29, 2024

@bot-gradle cherry-pick to release

@bot-gradle
Copy link
Collaborator

I have cherry-picked to PR #28997.

github-merge-queue bot pushed a commit that referenced this pull request Apr 29, 2024
@lkasso lkasso removed the in:gradle-distribution gradle distribution content, size, bundled dependencies label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:documentation Documentation content from:contributor PR by an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants