Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP executer is being treated as a CC executer #29047

Merged
merged 2 commits into from
May 11, 2024

Conversation

6hundreds
Copy link
Member

Part of #29045

@6hundreds
Copy link
Member Author

@bot-gradle test acc

@gradle gradle deleted a comment from 6hundreds May 8, 2024
@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@6hundreds
Copy link
Member Author

@bot-gradle test this

@gradle gradle deleted a comment from 6hundreds May 8, 2024
@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@@ -84,7 +84,8 @@ public static boolean isNotConfigCache() {
}

public static boolean isConfigCache() {
return getSystemPropertyExecuter() == Executer.configCache;
return getSystemPropertyExecuter() == Executer.configCache ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅 Introduce local variable for getSystemPropertyExecuter() lookup

Copy link
Member

@bamboo bamboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@6hundreds 6hundreds added this pull request to the merge queue May 10, 2024
@bot-gradle bot-gradle added this to the 8.9 RC1 milestone May 10, 2024
@bot-gradle
Copy link
Collaborator

The merge queue build has failed. Click here to see all failures.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2024
@bamboo bamboo added this pull request to the merge queue May 10, 2024
Merged via the queue into master with commit b45d8c9 May 11, 2024
22 checks passed
@bamboo bamboo deleted the 6hundreds/ip-executor-implies-cc-executor branch May 11, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants