Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to improve cache hits by removing a CI-only action from Test … #29071

Merged
merged 1 commit into from May 11, 2024

Conversation

big-guy
Copy link
Member

@big-guy big-guy commented May 8, 2024

…tasks

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@big-guy big-guy self-assigned this May 8, 2024
@big-guy
Copy link
Member Author

big-guy commented May 9, 2024

@bot-gradle test

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@big-guy big-guy marked this pull request as ready for review May 10, 2024 22:39
@big-guy big-guy requested a review from a team as a code owner May 10, 2024 22:39
@big-guy
Copy link
Member Author

big-guy commented May 10, 2024

@bot-gradle merge

@bot-gradle bot-gradle added this pull request to the merge queue May 10, 2024
@bot-gradle bot-gradle added this to the 8.9 RC1 milestone May 10, 2024
@big-guy big-guy added this to the 8.9 RC1 milestone May 10, 2024
Merged via the queue into master with commit 4c88582 May 11, 2024
55 of 58 checks passed
@bot-gradle bot-gradle deleted the sg/89/better-cache-hits branch May 11, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants