Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ignore build event listener failures #7510

Merged
merged 2 commits into from Oct 24, 2018
Merged

Do not ignore build event listener failures #7510

merged 2 commits into from Oct 24, 2018

Conversation

adammurdoch
Copy link
Member

Context

This PR fixes error handling for various listener types so that exceptions thrown by these listeners are not ignored:

  • BuildListener instances added via Gradle
  • TaskExecutionGraphListener instances added via TaskGraph
  • Action instances added via TaskGraph
  • ProjectEvaluationListener instances added via Gradle

Contributor Checklist

  • Review Contribution Guidelines
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
  • Provide unit tests (under <subproject>/src/test) to verify logic
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation
  • Recognize contributor in release notes

@adammurdoch
Ensure that exceptions thrown by various build event actions and list…
7fe1cb4 
…eners are reported on the console and cause the build to fail.

Previously, failures thrown by `BuildListener`, `TaskExecutionGraphListener` and `ProjectEvaluationListener` listeners and also by `Action` instances passed to `taskGraph.whenReady()` would be ignored.
@adammurdoch
Simplify some generics and create less garbage when running `Runnable…
3939062 
…BuildOperation` build operations.
@adammurdoch adammurdoch merged commit a0907dc into release Oct 24, 2018
This was referenced Oct 24, 2018
Closed
Closed
@big-guy big-guy added this to the 4.10.3 milestone Nov 29, 2018
@adammurdoch adammurdoch deleted the am/listener-failures branch December 24, 2018 21:32
This was referenced May 28, 2021
Open
Closed
Open
Open
Open
Closed
Open
Closed
Open
Closed
@renovate-bot renovate-bot mentioned this pull request May 28, 2021
Closed
1 task
This was referenced May 28, 2021
Open
Closed
Closed
Open
Closed
Open
Closed
Open
Closed
Open
Open
Open
This was referenced Jun 6, 2021
Closed
Closed
Closed
Open
Open
Open
Open
Open
Open
This was referenced Jun 20, 2021
Open
Closed
This was referenced Jul 13, 2021
Open
Closed
This was referenced Jul 14, 2021
Closed
Closed
Merged
Merged
This was referenced Jul 22, 2021
Closed
Closed
Closed
Closed
This was referenced Jul 28, 2021
Open
Closed
This was referenced Aug 6, 2021
Open
Closed
Open
Closed
Closed
@renovate renovate bot mentioned this pull request Aug 13, 2021
Closed
1 task
hyochan pushed a commit to dooboolab-community/flutter_inapp_purchase that referenced this pull request Mar 13, 2023
@renovate
Update dependency gradle to v4.10.3 (#397)
c1f6783 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [gradle](https://gradle.org)
([source](https://togithub.com/gradle/gradle)) | patch | `4.10.2` ->
`4.10.3` |

---

### Release Notes

<details>
<summary>gradle/gradle</summary>

###
[`v4.10.3`](https://togithub.com/gradle/gradle/releases/tag/v4.10.3):
4.10.3

This bug-fix release contains **3** changes to Gradle 4.10.2:

-
[gradle/gradle#7510
-
[gradle/gradle#6849
-
[gradle/gradle#7014

It also incorporates all fixes to 4.10.1 and 4.10.2.

We recommend that you use Gradle 4.10.3 over 4.10, 4.10.1 and 4.10.2.

#### Upgrade Instructions

Switch your build to use Gradle 4.10.3 by updating your wrapper
properties:

`./gradlew wrapper --gradle-version=4.10.3`

Standalone downloads are available at https://gradle.org/install.

#### Reporting Problems

If you find a problem with Gradle 4.10.3, please file a bug on [GitHub
Issues](https://togithub.com/gradle/gradle/issues) adhering to our issue
guidelines. If you're not sure you're encountering a bug, please use the
[forum](https://discuss.gradle.org/c/help-discuss).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/dooboolab/flutter_inapp_purchase).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.10.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adammurdoch @big-guy