Ignore missing source roots for incremental compilation #8195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lptr
reviewed
Jan 9, 2019
| @@ -569,6 +569,25 @@ sourceSets { | |||
| output.contains("Full recompilation is required because the source roots could not be inferred.") | |||
| } | |||
|
|
|||
| def "missing files are ignored of source roots"() { | |||
| @@ -569,6 +569,25 @@ sourceSets { | |||
| output.contains("Full recompilation is required because the source roots could not be inferred.") | |||
| } | |||
|
|
|||
| def "missing files are ignored of source roots"() { | |||
| buildFile << "compileJava.source([file('extra-java'), file('other'), fileTree('missing-tree'), file('missing-file')])" | |||
There was a problem hiding this comment.
Let's break this into multiple lines.
Also, what is the difference between other and missing-file? Seems to be both missing. For simplicity's sake we could also put the sources under src/main/java so we could remove extra-java as well.
There was a problem hiding this comment.
I now only add missing-tree and missing-file.
|
|
||
| then: | ||
| outputs.recompiledClasses("A", "B") | ||
| !output.contains("Full recompilation is required because the source roots could not be inferred.") |
There was a problem hiding this comment.
It's not an isolated problem, but I feel such tests are way too brittle. Can we at least get this string from a constant in the production code maybe?
There was a problem hiding this comment.
I can remove this line, given that a full recompilation would always meant the C is compiled as well.
|
@lptr PTAL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8194.