Allow converting singleton file tree to directory trees #8387
Conversation
|
Fixes #8394. |
There was a problem hiding this comment.
I think this looks good as a fix for the particular problem. What I don't see is how we could prove there are no other holes like this. Can we do something to that end?
A bit of simplification among FileTree implementations (similar maybe to what @adammurdoch did in #8403) could be nice, too.
| @@ -45,4 +50,31 @@ class DefaultSingletonFileTreeTest extends Specification { | |||
| } | |||
| 0 * visitor._ | |||
| } | |||
|
|
|||
| def "can be converted to a directory tree"() { | |||
There was a problem hiding this comment.
Should we mention the @Issue that triggered this?
| @@ -45,4 +50,31 @@ class DefaultSingletonFileTreeTest extends Specification { | |||
| } | |||
| 0 * visitor._ | |||
| } | |||
|
|
|||
| def "can be converted to a directory tree"() { | |||
| File f = temporaryFolder.file('test-file') | |||
There was a problem hiding this comment.
Nit: let's not use single-letter variable names.
|
@lptr I added an extra test for the remaining method on We may add a separate test which would take a file tree and then exercises all methods. Then we would create a subclass for every file tree implementation to test it. I opened https://github.com/gradle/build-cache/issues/1476 for consolidating the file tree implementations. |
|
LGTM. Let's consolidate the creation of |
No description provided.