Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selection of both the library and platform of a component #8427

Merged
merged 1 commit into from Feb 6, 2019

Conversation

melix
Copy link
Contributor

@melix melix commented Feb 5, 2019

Context

For published POM files, we want to allow selecting both the
library and platform variants of a component. They are effectively
different things. This commit makes it possible by assigning a
different capability to the platform variants.

Fixes #8420

@melix melix added this to the 5.2.1 milestone Feb 5, 2019
@melix melix self-assigned this Feb 5, 2019
@melix melix requested a review from ljacomet February 5, 2019 17:28
Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

For published POM files, we want to allow selecting both the
library and platform variants of a component. They are effectively
different things. This commit makes it possible by assigning a
different capability to the platform variants.

Fixes #8420
@melix melix merged commit 25e1b3a into release Feb 6, 2019
@melix melix deleted the cc/dm/fix-8420 branch February 6, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants