Introduce task for JaCoCo plugin for enforcing code coverage metrics

subprojects/jacoco/src/integTest/groovy/org/gradle/testing/jacoco/plugins/JacocoPluginCheckCoverageIntegrationTest.groovy

@@ -23,7 +23,9 @@ import spock.lang.Unroll
 class JacocoPluginCheckCoverageIntegrationTest extends AbstractIntegrationSpec {
 
     private final JavaProjectUnderTest javaProjectUnderTest = new JavaProjectUnderTest(testDirectory)
-    private final static String[] TEST_AND_JACOCO_REPORT_TASK_PATHS = [':test', ':jacocoTestReport'] as String[]
+    private final static String[] TEST_TASK_PATH = [':test'] as String[]
+    private final static String[] JACOCO_REPORT_TASK_PATH = [':jacocoTestReport'] as String[]
+    private final static String[] TEST_AND_JACOCO_REPORT_TASK_PATHS = TEST_TASK_PATH + JACOCO_REPORT_TASK_PATH
     private final static String[] INTEG_TEST_AND_JACOCO_REPORT_TASK_PATHS = [':integrationTest', ':jacocoIntegrationTestReport'] as String[]
 
     def setup() {
@@ -310,6 +312,43 @@ class JacocoPluginCheckCoverageIntegrationTest extends AbstractIntegrationSpec {
         INTEG_TEST_AND_JACOCO_REPORT_TASK_PATHS | 'jacocoIntegrationTestReport' | Limits.Insufficient.CLASS_METRIC_MISSED_COUNT | 'classes missed count is 0.0, but expected minimum is 0.5'
     }
 
+    def "changes to violation rules re-run task"() {
+        buildFile << """
+            jacocoTestReport {
+                violationRules {
+                    rule {
+                        $Limits.Sufficient.LINE_METRIC_COVERED_RATIO
+                    }
+                }
+            }
+        """
+
+        when:
+        succeeds TEST_AND_JACOCO_REPORT_TASK_PATHS
+
+        then:
+        executedAndNotSkipped(TEST_AND_JACOCO_REPORT_TASK_PATHS)
+
+        when:
+        succeeds TEST_AND_JACOCO_REPORT_TASK_PATHS
+
+        then:
+        executed(TEST_AND_JACOCO_REPORT_TASK_PATHS)
+        skipped(TEST_AND_JACOCO_REPORT_TASK_PATHS)
+
+        when:
+        buildFile << """
+            jacocoTestReport.violationRules.rules[0].limits[0].maximum = 0.5            
+        """
+
+        fails TEST_AND_JACOCO_REPORT_TASK_PATHS
+
+        then:
+        executed(JACOCO_REPORT_TASK_PATH)
+        skipped(TEST_TASK_PATH)
+        errorOutput.contains("Rule violated for bundle $testDirectory.name: lines covered ratio is 1.0, but expected maximum is 0.5")
+    }
+
     static class Limits {
         static class Sufficient {
             static final String LINE_METRIC_COVERED_RATIO = Limits.create('LINE', 'COVEREDRATIO', '0.0', '1.0')

subprojects/jacoco/src/main/java/org/gradle/testing/jacoco/tasks/rules/JacocoLimit.java

@@ -17,20 +17,25 @@
 package org.gradle.testing.jacoco.tasks.rules;
 
 import org.gradle.api.Incubating;
+import org.gradle.api.tasks.Input;
+import org.gradle.api.tasks.Optional;
+
+import java.io.Serializable;
 
 /**
  * Defines a Jacoco rule limit.
  *
  * @since 4.0
  */
 @Incubating
-public interface JacocoLimit {
+public interface JacocoLimit extends Serializable {
 
     /**
      * The counter that applies to the limit as defined by
      * <a href="http://www.eclemma.org/jacoco/trunk/doc/api/org/jacoco/core/analysis/ICoverageNode.CounterEntity.html">org.jacoco.core.analysis.ICoverageNode.CounterEntity</a>.
      * Valid values are INSTRUCTION, LINE, BRANCH, COMPLEXITY, METHOD and CLASS. Defaults to INSTRUCTION.
      */
+    @Input
     String getCounter();
 
     void setCounter(String counter);
@@ -40,20 +45,25 @@ public interface JacocoLimit {
      * <a href="http://www.eclemma.org/jacoco/trunk/doc/api/org/jacoco/core/analysis/ICounter.CounterValue.html">org.jacoco.core.analysis.ICounter.CounterValue</a>.
      * Valid values are TOTALCOUNT, MISSEDCOUNT, COVEREDCOUNT, MISSEDRATIO and COVEREDRATIO. Defaults to COVEREDRATIO.
      */
+    @Input
     String getValue();
 
     void setValue(String value);
 
     /**
      * Gets the minimum expected value for limit. Default to null.
      */
+    @Input
+    @Optional
     Double getMinimum();
 
     void setMinimum(Double minimum);
 
     /**
      * Gets the maximum expected value for limit. Default to null.
      */
+    @Input
+    @Optional
     Double getMaximum();
 
     void setMaximum(Double maximum);

subprojects/jacoco/src/main/java/org/gradle/testing/jacoco/tasks/rules/JacocoViolationRule.java

@@ -20,7 +20,10 @@
 import groovy.lang.DelegatesTo;
 import org.gradle.api.Action;
 import org.gradle.api.Incubating;
+import org.gradle.api.tasks.Input;
+import org.gradle.api.tasks.Nested;
 
+import java.io.Serializable;
 import java.util.List;
 
 import static groovy.lang.Closure.DELEGATE_FIRST;
@@ -31,13 +34,14 @@
  * @since 4.0
  */
 @Incubating
-public interface JacocoViolationRule {
+public interface JacocoViolationRule extends Serializable {
 
     void setEnabled(boolean enabled);
 
     /**
      * Indicates if the rule should be used when checking generated coverage metrics.
      */
+    @Input
     boolean isEnabled();
 
     void setElement(String element);
@@ -47,6 +51,7 @@ public interface JacocoViolationRule {
      * <a href="http://www.eclemma.org/jacoco/trunk/doc/api/org/jacoco/core/analysis/ICoverageNode.ElementType.html">org.jacoco.core.analysis.ICoverageNode.ElementType</a>.
      * Valid scope values are BUNDLE, PACKAGE, CLASS, SOURCEFILE and METHOD. Defaults to BUNDLE.
      */
+    @Input
     String getElement();
 
     void setIncludes(List<String> includes);
@@ -55,6 +60,7 @@ public interface JacocoViolationRule {
      * List of elements that should be included in check. Names can use wildcards (* and ?).
      * If left empty, all elements will be included. Defaults to [*].
      */
+    @Input
     List<String> getIncludes();
 
     void setExcludes(List<String> excludes);
@@ -63,11 +69,13 @@ public interface JacocoViolationRule {
      * List of elements that should be excluded from check. Names can use wildcards (* and ?).
      * If left empty, no elements will be excluded. Defaults to an empty list.
      */
+    @Input
     List<String> getExcludes();
 
     /**
      * Gets all limits defined for this rule. Defaults to an empty list.
      */
+    @Nested
     List<JacocoLimit> getLimits();
 
     /**

subprojects/jacoco/src/main/java/org/gradle/testing/jacoco/tasks/rules/JacocoViolationRulesContainer.java

@@ -20,7 +20,7 @@
 import groovy.lang.DelegatesTo;
 import org.gradle.api.Action;
 import org.gradle.api.Incubating;
-import org.gradle.api.tasks.Internal;
+import org.gradle.api.tasks.Input;
 
 import java.util.List;
 
@@ -39,13 +39,13 @@ public interface JacocoViolationRulesContainer {
     /**
      * Specifies whether build should fail in case of rule violations. Defaults to true.
      */
-    @Internal
+    @Input
     boolean isFailOnViolation();
 
     /**
      * Gets all violation rules. Defaults to an empty list.
      */
-    @Internal
+    @Input
     List<JacocoViolationRule> getRules();
 
     /**