Inject a filtering classloader for annotation processor classpath #9899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbroyer
reviewed
Jul 11, 2019
|
|
||
| ${mavenCentralRepository()} | ||
|
|
||
| if (JavaVersion.current().java8) { |
There was a problem hiding this comment.
Note that the plugin does this check already, you can declare the dependency unconditionally; the errorproneJavac configuration will only ever be resolved when running with Java 8.
| tasks.withType(JavaCompile).configureEach { | ||
| options.fork = true | ||
| options.errorprone { | ||
| check("DoubleBraceInitialization", net.ltgt.gradle.errorprone.CheckSeverity.ERROR) |
There was a problem hiding this comment.
You may have wanted to use error("DoubleBraceInitialization") instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9897
When an annotation processor path is set, but there are no declared annotation processors, the Java compiler creates a new classloader for the annotation processor classpath that hangs off of the system classloader which may have other classes visible that could interfere with an annotation processor. This change injects a filter in between the annotation processor classpath and the system classloader exactly like what we do when an annotation processor is declared.