Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gradleKotlinDsl() dependency declaration throwing a ClassCastException #9920

Merged
merged 1 commit into from Jul 10, 2019
Merged

Fix gradleKotlinDsl() dependency declaration throwing a ClassCastException #9920

merged 1 commit into from Jul 10, 2019

Conversation

eskatos
Copy link
Member

@eskatos eskatos commented Jul 10, 2019

This PR fixes the regression in 5.5 reported in #9919

@eskatos
Fix kotlin-dsl regression #9919
6526801 
Signed-off-by: Paul Merlin <paul@gradle.com>
@eskatos eskatos added this to the 5.5.1 milestone Jul 10, 2019
@eskatos eskatos requested a review from bamboo July 10, 2019 08:30
@eskatos eskatos self-assigned this Jul 10, 2019
bamboo
bamboo approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@bamboo bamboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@eskatos eskatos changed the base branch from master to release July 10, 2019 14:12
@eskatos eskatos merged commit f45238e into release Jul 10, 2019
@eskatos eskatos deleted the eskatos/kotlin-dsl/regression-9919 branch July 10, 2019 14:13
@eskatos eskatos mentioned this pull request Jul 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bamboo bamboo bamboo approved these changes

Assignees

@eskatos eskatos

Labels
in:kotlin-dsl
Projects
None yet
Milestone
5.5.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eskatos @bamboo