Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declarativize NiA without custom software types #16

Merged
merged 31 commits into from
Apr 25, 2024

Conversation

tresat
Copy link
Member

@tresat tresat commented Apr 19, 2024

No description provided.

@tresat tresat changed the base branch from main to main-declarative April 22, 2024 19:50
@tresat tresat self-assigned this Apr 22, 2024
@tresat tresat marked this pull request as ready for review April 22, 2024 19:50
@tresat tresat changed the title Declarativize NiA without custom software type Declarativize NiA without custom software types Apr 22, 2024
@tresat tresat force-pushed the tt/declarative-no-conventions branch from 4e4392a to 29042d5 Compare April 22, 2024 20:48
- Include declarative-prototype project.
- Apply android ecosystem plugin.
- Create declarative file.
- Remove some versions in VC and adjust some deps to avoid version conflict in plugins.
- Advance to core/data project.
- Restore README.
Build file '/home/runner/work/nowinandroid/nowinandroid/now-in-android/benchmarks/build.gradle.kts' line: 40

* What went wrong:
Script compilation error:

  Line 40:     configureFlavors(this) { flavor ->
                                ^ Type mismatch: inferred type is TestExtension! but CommonExtension<*, *, *, *, *, *> was expected

1 error
- Fixes issue in benchmarks and removes need for change.
- Tests now build and run, but fail due to: java.lang.NoClassDefFoundError: Could not initialize class JvmUnitTestDemoAssetManager and Roborazzi image comparison failure - expected, need to continue to setup test stuff.
Only a few failing tests left.
@tresat tresat force-pushed the tt/declarative-no-conventions branch from ead5c90 to 042fceb Compare April 24, 2024 14:18
Copy link

Combined test coverage report

Overall Project 39.33%

There is no coverage information present for the Files changed

Copy link

Combined test coverage report

Overall Project 39.34%

There is no coverage information present for the Files changed

@big-guy big-guy merged commit 1ccdee9 into main-declarative Apr 25, 2024
2 of 3 checks passed
@big-guy big-guy deleted the tt/declarative-no-conventions branch April 25, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants