Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for case of inherited from Test tasks with own executers #163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhurs
Copy link

@zhurs zhurs commented Dec 7, 2022

Now plugin relies on task executer class, but this approach don't work with inherited tasks with own executers, for example with Kotlin Multiplatform Tests.

There are some issues for this problem:
#116
#140

Possible solution is to store last result outside of the retry executer.

Signed-off-by: Sergey Zhuravlev <sergey.zhuravlev@gmail.com>
@zhurs zhurs force-pushed the fix-collective-work-with-kotlin-multiplatform branch from ff59859 to a7fd65b Compare December 7, 2022 11:11
@marcphilipp
Copy link
Contributor

@zhurs Could you please elaborate how this fixes the integration issue with KMPP? As far as I can tell, there would be multiple instances of the KMPP TestExecuter implementation created so the structure would be KotlinJvmTest$Executor(RetryTestExecutor(KotlinJvmTest$Executor(...))), wouldn't it?

@zhurs
Copy link
Author

zhurs commented Dec 15, 2022

@marcphilipp You are absolutely right.
But KMMP executer just add "[jvm]" suffix to the test names, after fix suffix will be added twice - it is not very good, but at least retry will work correctly.
I don't see better way to fix issue ;-(

On the other hands fix itself is not bad - it just remove requirement of specific executer class, it will work with other Executer delegate-chains.

@JavierSegoviaCordoba
Copy link

Can this be revised?

@dtretyakov
Copy link

@marcphilipp do you have a better solution in mind to address the original problem with test runner in Kotlin MPP projects?

If so could you please share the plan when they will be properly supported.

@pshevche
Copy link
Member

@marcphilipp do you have a better solution in mind to address the original problem with test runner in Kotlin MPP projects?

If so could you please share the plan when they will be properly supported.

We don't have a clear roadmap for it yet. This is a common request (also see #116), so we'll take it into account when planning the next set of features for this plugin. Unfortunately, I don't have more to share at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants