feat(remote/aws): support AWS Secrets Manager as remote component #718
+681
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hainenber
changed the title
|
I think it would be nice if it could poll but set the default to not poll. Most of our pulling mechanisms support it so it would be odd if this one did not have that capability. |
|
Thanks Matt! I'll implement the poller and fix whatever makes the tests failed. Maybe in the long run, we can have a reusable implementation. But that's for another day, I suppose :D |
hainenber
changed the title
hainenber
commented
May 1, 2024
| @@ -106,11 +100,11 @@ func (s *Component) Run(ctx context.Context) error { | |||
| func (s *Component) Update(args component.Arguments) error { | |||
| newArgs := args.(Arguments) | |||
|
|
|||
| s3cfg, err := generateS3Config(newArgs) | |||
| awsCfg, err := aws_common_config.GenerateAWSConfig(newArgs.Options.Client) | |||
| if err != nil { | |||
| return nil | |||
There was a problem hiding this comment.
@rfratto pinging 'cause you authored this in the past. Do you know why this returns nil in the present of non-nil error? 👀
docs/sources/reference/components/remote.aws.secrets_manager.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/remote.aws.secrets_manager.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/remote.aws.secrets_manager.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/remote.aws.secrets_manager.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/remote.aws.secrets_manager.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/remote.aws.secrets_manager.md
Outdated
Show resolved
Hide resolved
clayton-cornell
added
the
type/docs
rfratto
added
the
backport-to-agent:no
|
Docs look ok. |
hainenber
force-pushed
the
support-aws-secret-manager-as-remote-component
branch
from
68ec808
to
e453b57
Compare
…tions used in remote AWS components Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
…n test in Docker-present env Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
…ial poller is configured Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
force-pushed
the
support-aws-secret-manager-as-remote-component
branch
from
e453b57
to
20a34d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Closes #689
Notes to the Reviewer
component.Componentincomponenttestin order to verify the component's health status. Is this A-OK?PR Checklist