Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS s3 exporter component #730

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Imshelledin21
Copy link

PR Description

Adding in an otelcol.exporter.awss3 component.

Which issue(s) this PR fixes

#256

Fixes #256

Notes to the Reviewer

Uses the upstream opentelemetry-collector-contrib awss3exporter

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label May 2, 2024
@rfratto rfratto added the backport-to-agent:no PR should NOT be backported to the agent repo. label May 3, 2024
Imshelledin21 and others added 12 commits May 6, 2024 15:23
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Comment on lines +27 to +29
region = "REGION"
s3_bucket = "BUCKET_NAME"
s3_prefix = "PREFIX"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
region = "REGION"
s3_bucket = "BUCKET_NAME"
s3_prefix = "PREFIX"
region = "<REGION>"
s3_bucket = "<BUCKET_NAME>"
s3_prefix = "<PREFIX>"

## Usage

```alloy
otelcol.exporter.awss3 "LABEL" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
otelcol.exporter.awss3 "LABEL" {
otelcol.exporter.awss3 "<LABEL>" {

}
}
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Replace the following:
* _`<LABEL>`_: The label for the `otelcol.exporter.awss3` component.
* _`<REGION>`_: The AWS region.
* _`<BUCKET_NAME>`_: The S3 bucket.
* _`<PREFIX>`_: The prefix for the S3 key.

This implements the Placeholder Variables: https://grafana.com/docs/writers-toolkit/write/style-guide/write-for-developers/#placeholder-variables and the style is matched to the other component topics.

Comment on lines +110 to +111
- `none` (default): No compression will be applied
- `gzip`: Files will be compressed with gzip. **This doesn't support `sumo_ic`marshaler.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `none` (default): No compression will be applied
- `gzip`: Files will be compressed with gzip. **This doesn't support `sumo_ic`marshaler.**
- `none` (default): File compression isn't used.
- `gzip`: Files are compressed with Gzip. **This doesn't support `sumo_ic`marshaler.**


Encoding overrides the marshaler if it's present and sets it to use the encoding extension defined in the collector configuration.

Refer to the Open Telemetry [encoding extensions] documentation for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Refer to the Open Telemetry [encoding extensions] documentation for more information.
Refer to the Open Telemetry [encoding extensions][] documentation for more information.


Marshaler determines the format of data sent to AWS S3. Currently, the following marshalers are implemented:

- `otlp_json` (default): the [OpenTelemetry Protocol format](https://github.com/open-telemetry/opentelemetry-proto), represented as json.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `otlp_json` (default): the [OpenTelemetry Protocol format](https://github.com/open-telemetry/opentelemetry-proto), represented as json.
- `otlp_json` (default): the [OpenTelemetry Protocol format](https://github.com/open-telemetry/opentelemetry-proto), represented as JSON.

@clayton-cornell clayton-cornell requested a review from a team May 23, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-agent:no PR should NOT be backported to the agent repo. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS s3 exporter
3 participants