Modules: add relative path support to import.file #789
+493
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l context to the module. The scope has one value "module_path" that represents the dir path of the current module. It can be used in combination with the path_join stdlib function to import modules via relative path.
- import file in import file with relative path - import folder in import folder with relative path - import file in import string with relative path
wildum
force-pushed
the
modules-support-relative-path
branch
from
538437d
to
000b538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR introduces an ArgScope to the loader that will be used as a parent scope when evaluating the nodes in the module. For now, it contains only one variable "module_path" that represents the current path of the module and can be used in the config. It also adds the stdlib function "path_join". Both can be used together to configure a relative path on the import.file block.
The following use-cases are currently supported:
Which issue(s) this PR fixes
Fixes #786
Notes to the Reviewer
The PR can be reviewed commit by commit.
PR Checklist