New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live debugging service with prometheus.relabel #797
base: xray
Are you sure you want to change the base?
Conversation
da55944
to
47650ee
Compare
Looks reasonable, tested both wide 1,000 streams and deep 1 stream with 1m metrics. Long term some changes around when to flush and the channel would be nice. But performance is totally reasonable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start! some comments around readability and naming.
…void expensive string computation
@ptodev @thampiotr thanks for your feedback! |
THIS PR WILL BE MERGED TO A FEATURE BRANCH WHICH WILL RECEIVE A FEW OTHER PRs BEFORE BEING READY TO BE MERGED ON MAIN
This PR is the first part of the live debugging functionality.
It creates live debugging as a service and connects the prometheus.relabel component to it (an easy first candidate).
A stream to a component can be opened via
http://localhost:12345/api/v0/web/debug/ + componentID
.This adds a callback to the x-ray service that the component can retrieve and use to pass data as a string which will be directly flushed to the HTTP client.
It supports components that are inside modules.
Fixes #790