Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override the cluster headless service port name for Istio support #820

Merged
merged 10 commits into from May 16, 2024

Conversation

josh-thisisbud
Copy link
Contributor

@josh-thisisbud josh-thisisbud commented May 10, 2024

This will be needed for an Istio mesh based installation due to this issue with headless services + Istio - https://istio.io/latest/docs/ops/common-problems/network-issues/#503-error-while-accessing-headless-services

PR Description

Which issue(s) this PR fixes

Fixes #800

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

This will be needed for an Istio mesh based installation due to this issue with headless services + Istio - https://istio.io/latest/docs/ops/common-problems/network-issues/#503-error-while-accessing-headless-services
@CLAassistant
Copy link

CLAassistant commented May 10, 2024

CLA assistant check
All committers have signed the CLA.

@rfratto rfratto added the backport-to-agent PR should be backported to the agent repo. label May 14, 2024
@josh-thisisbud
Copy link
Contributor Author

What needs to be done to get this over the line? As it's a small change in the Helm Chart.
Are you expecting me to backport this to Grafana agent before this can be merged?

@josh-thisisbud
Copy link
Contributor Author

@rfratto as you added the label, would you answer the above question for me?

@rfratto
Copy link
Member

rfratto commented May 16, 2024

What needs to be done to get this over the line? As it's a small change in the Helm Chart.

Thanks for the ping, and sorry this has been sitting around. I'll review this right after sending this comment.

Are you expecting me to backport this to Grafana agent before this can be merged?

No, sorry; that label is for the maintainers to track what they need to backport after a PR has been merged into main. I wouldn't want contributors to have to go through the effort of backporting.

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Two small comments but this should be ready to go soon.

CHANGELOG.md Outdated Show resolved Hide resolved
operations/helm/charts/alloy/values.yaml Outdated Show resolved Hide resolved
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this!

@rfratto rfratto merged commit 1cdd942 into grafana:main May 16, 2024
15 checks passed
rfratto added a commit to rfratto/alloy that referenced this pull request May 22, 2024
@rfratto rfratto mentioned this pull request May 22, 2024
rfratto added a commit that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-agent PR should be backported to the agent repo.
Projects
None yet
3 participants