Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path_join function to the stdlib #821

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

wildum
Copy link
Contributor

@wildum wildum commented May 10, 2024

PR Description

Adding this function to the stdlib is needed to move forward with the relative path solution that is implemented for the modules. This function should also be useful in other scenarios.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this implementation but I'm planning on opening a proposal for a fleshed out set of stdlib functions to add.

I'd like for us to hold off on this until that proposal is available and we have consensus on it, mainly because it may establish naming conventions that we'd want to follow, or other details about new functions that this doesn't account for (such as the stability level of functions).

If you think we need this sooner, I'd recommend that it at least not be GA, and for us to find a way to return an error if it's used in non-GA Alloy instances.

@wildum wildum marked this pull request as draft May 10, 2024 14:58
@wildum
Copy link
Contributor Author

wildum commented May 10, 2024

I'm OK to wait. I'd like the relative path for modules to make it to 1.2 but since that we are in the process of releasing 1.1 we have time. Thanks for the heads-up, changing this PR to draft for now

@wildum wildum mentioned this pull request May 24, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants