Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(prometheus/scrape): add example for K8s auth #829

Merged

Conversation

hainenber
Copy link
Contributor

PR Description

Which issue(s) this PR fixes

Closes #827

Notes to the Reviewer

PR Checklist

Signed-off-by: hainenber <dotronghai96@gmail.com>
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label May 13, 2024
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor tweak and we should be able to merge this one :-)

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@clayton-cornell clayton-cornell enabled auto-merge (squash) May 14, 2024 15:12
@rfratto rfratto added the backport-to-agent PR should be backported to the agent repo. label May 14, 2024
@clayton-cornell clayton-cornell merged commit d8831a5 into grafana:main May 14, 2024
16 checks passed
github-actions bot pushed a commit that referenced this pull request May 14, 2024
* docs(prometheus/scrape): add example for K8s auth

Signed-off-by: hainenber <dotronghai96@gmail.com>

* Apply suggestions from Clayton's code review

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Apply suggestions from 2nd Clayton's code review

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

---------

Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
(cherry picked from commit d8831a5)
github-actions bot pushed a commit that referenced this pull request May 14, 2024
* docs(prometheus/scrape): add example for K8s auth

Signed-off-by: hainenber <dotronghai96@gmail.com>

* Apply suggestions from Clayton's code review

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Apply suggestions from 2nd Clayton's code review

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

---------

Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
(cherry picked from commit d8831a5)
clayton-cornell pushed a commit that referenced this pull request May 14, 2024
* docs(prometheus/scrape): add example for K8s auth

Signed-off-by: hainenber <dotronghai96@gmail.com>

* Apply suggestions from Clayton's code review

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Apply suggestions from 2nd Clayton's code review

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

---------

Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
(cherry picked from commit d8831a5)

Co-authored-by: Đỗ Trọng Hải <41283691+hainenber@users.noreply.github.com>
clayton-cornell pushed a commit that referenced this pull request May 14, 2024
* docs(prometheus/scrape): add example for K8s auth

Signed-off-by: hainenber <dotronghai96@gmail.com>

* Apply suggestions from Clayton's code review

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Apply suggestions from 2nd Clayton's code review

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

---------

Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
(cherry picked from commit d8831a5)

Co-authored-by: Đỗ Trọng Hải <41283691+hainenber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.0 backport release/v1.1 backport-to-agent PR should be backported to the agent repo. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs feedback: Scrape jobs can't authenticate with K8s
3 participants